Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Adds amp script in amp boilerplate #4636

Merged
merged 5 commits into from
Apr 13, 2022
Merged

Adds amp script in amp boilerplate #4636

merged 5 commits into from
Apr 13, 2022

Conversation

DarioR01
Copy link
Contributor

@DarioR01 DarioR01 commented Apr 12, 2022 •
edited
Loading

Part Of: bbc/simorgh#10011

Overall change: added amp script export to amp boilerplate to use it in Simorgh.

Code changes:

  • Update tests
  • Added amp script to amp boilerplate exports as AMP_SCRIPT_JS
  • (BBC contributors only) This PR follows the repository use guidelines
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DarioR01 DarioR01 self-assigned this Apr 12, 2022
@DarioR01 DarioR01 added the technical-work Technical debt, support work and building new technical tools and features label Apr 12, 2022
HarveyPeachey
HarveyPeachey reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@HarveyPeachey HarveyPeachey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update the expected exports unit tests

@DarioR01 DarioR01 merged commit 2ef5505 into latest Apr 13, 2022
@DarioR01 DarioR01 deleted the feat-amp-script-boilerplate branch April 13, 2022 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HarveyPeachey HarveyPeachey HarveyPeachey approved these changes

@amoore108 amoore108 amoore108 approved these changes

@jroebu14 jroebu14 jroebu14 approved these changes

Assignees

@DarioR01 DarioR01

Labels
technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DarioR01 @HarveyPeachey @jroebu14 @amoore108