This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Fixes BBC Blocks Dark Mode Base64 String Size #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarveyPeachey
changed the title
HarveyPeachey
added
the
cross-team
amoore108
approved these changes
Apr 8, 2022
ryanmccombe
approved these changes
Apr 8, 2022
DarioR01
approved these changes
Apr 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of bbc/simorgh#10004
Overall change: This PR fixes the base 64 string for the dark mode BBC blocks image which is used in placeholders, this takes the normal BBC Blocks logo, replaces the fill colour in the SVG format, and has been converted back into the base 64 format.
Makes the image 3x smaller, from 8.27 KB to 2.70 KB.
Code changes: