Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Remove old fonts #4568

Merged
merged 16 commits into from
Sep 30, 2021
Merged

Remove old fonts #4568

merged 16 commits into from
Sep 30, 2021

Conversation

nicola-d-bbc
Copy link
Contributor

@nicola-d-bbc nicola-d-bbc commented Sep 29, 2021 •
edited
Loading

Resolves N/A

Overall change: Remove old fonts and switched test URLs for new fonts to live.

Code changes:

  • Iskoola, Sinhala and Tamil fonts removed from psammead-styles
  • Update font URL in fonts.js to live URL (was previously test)
  • Iskoola, Sinhala and Tamil font scripts removed from gel-foundations and new font scripts refactored to new name
  • (BBC contributors only) This PR follows the repository use guidelines
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@nicola-d-bbc nicola-d-bbc marked this pull request as ready for review September 29, 2021 14:51
@pvaliani pvaliani self-requested a review September 30, 2021 12:39
jroebu14
jroebu14 approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@jroebu14 jroebu14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

DarioR01
DarioR01 approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@DarioR01 DarioR01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicola-d-bbc nicola-d-bbc merged commit 7c5eb05 into latest Sep 30, 2021
@nicola-d-bbc nicola-d-bbc deleted the remove-old-fonts branch September 30, 2021 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jroebu14 jroebu14 jroebu14 approved these changes

@pvaliani pvaliani pvaliani approved these changes

@DarioR01 DarioR01 DarioR01 approved these changes

Assignees

@nicola-d-bbc nicola-d-bbc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicola-d-bbc @jroebu14 @pvaliani @DarioR01 @HarveyPeachey