Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Sinhala font bold url fix #4565

Merged
merged 7 commits into from
Sep 22, 2021
Merged

Sinhala font bold url fix #4565

merged 7 commits into from
Sep 22, 2021

Conversation

HarveyPeachey
Copy link
Contributor

@HarveyPeachey HarveyPeachey commented Sep 22, 2021 •
edited
Loading

Resolves N/A

Overall change: Fixes bold font typo in URL for Noto Serif Sinhala

Code changes:

  • Replaces normal with bold in Noto Serif Sinhala font url
  • Updates snapshot
  • Bumps and updates change-logs for packages
  • (BBC contributors only) This PR follows the repository use guidelines
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@HarveyPeachey HarveyPeachey self-assigned this Sep 22, 2021
@HarveyPeachey HarveyPeachey added the cross-team For visibility for both World Service teams (Engage & Media) label Sep 22, 2021
@HarveyPeachey HarveyPeachey marked this pull request as ready for review September 22, 2021 11:29
@DarioR01 DarioR01 self-requested a review September 22, 2021 11:45
DarioR01
DarioR01 approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@DarioR01 DarioR01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvaliani pvaliani self-requested a review September 22, 2021 11:55
@pvaliani pvaliani merged commit 8ee0ac5 into latest Sep 22, 2021
@HarveyPeachey HarveyPeachey deleted the sinhala-font-bold-url-fix branch September 22, 2021 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DarioR01 DarioR01 DarioR01 approved these changes

@pvaliani pvaliani pvaliani approved these changes

Assignees

@HarveyPeachey HarveyPeachey

Labels
cross-team For visibility for both World Service teams (Engage & Media)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarveyPeachey @pvaliani @DarioR01