Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Tamil font fixes #4561

Merged
merged 11 commits into from
Sep 21, 2021
Merged

Tamil font fixes #4561

merged 11 commits into from
Sep 21, 2021

Conversation

HarveyPeachey
Copy link
Contributor

@HarveyPeachey HarveyPeachey commented Sep 21, 2021 •
edited
Loading

Resolves N/A

Overall change: Fixes incorrect font family in Tamil

Code changes:

  • Adds Tamil font to Storybook
  • Fixes font family name for noto sans tamil
  • Updates snapshots
  • Bumps packages
  • Updates changelogs
  • (BBC contributors only) This PR follows the repository use guidelines
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@pvaliani pvaliani marked this pull request as ready for review September 21, 2021 09:48
@HarveyPeachey HarveyPeachey added the cross-team For visibility for both World Service teams (Engage & Media) label Sep 21, 2021
MuhammadAHussain
MuhammadAHussain approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@MuhammadAHussain MuhammadAHussain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HarveyPeachey HarveyPeachey merged commit 5665dd5 into latest Sep 21, 2021
@HarveyPeachey HarveyPeachey deleted the tamil-font-fixes branch September 21, 2021 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MuhammadAHussain MuhammadAHussain MuhammadAHussain approved these changes

@amoore108 amoore108 amoore108 approved these changes

@jroebu14 jroebu14 jroebu14 approved these changes

Assignees

@HarveyPeachey HarveyPeachey

@nicola-d-bbc nicola-d-bbc

@pvaliani pvaliani

Labels
cross-team For visibility for both World Service teams (Engage & Media)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HarveyPeachey @jroebu14 @amoore108 @MuhammadAHussain @nicola-d-bbc @pvaliani