This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
psammead-brand forwardRefs to SvgWrapper #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryVerhoef
added
a11y
|
Checkout your storybook preview here http://psammead-preview.tools.bbc.co.uk/4426 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves bbc/simorgh#8855
Overall change: Makes changes to the psammead-brand and psammead-consent-banner component so that focus for these components can better be managed in Simorgh.
Code changes:
forwardRef.SvgWrapperstyled component, instead of on the link, since the link is conditionally rendered.tabindex="-1"attribute to the SvgWrapper so that it can be focussed without disrupting the tab order.SvgWrappercan be focussed using the ref when no url is given to the Banner.