Migrate to yarn #4335

jroebu14 · 2021-02-10T15:59:20Z

Resolves #4331

Overall change:
Replaces npm with yarn for package management.

Code changes:

NPM to Yarn command translations:

npm install -> yarn install install packages
npm ci -> yarn install --frozen-lockfile for deterministic builds based on lockfile
npm install --quiet -> yarn install --silent installs without console noise
npm update -> yarn upgrade upgrades all packages
npm install some-package -> yarn add some-package installs some-package
npm install --no-package-lock -> yarn install --no-lockfile do no generate a lock file on installing

I have assigned myself to this PR and the corresponding issues
Automated jest tests added (for new features) or updated (for existing features)
This PR requires manual testing

andrewscfc

Looks good, few thoughts:

Did you you use [yarn import(https://classic.yarnpkg.com/en/docs/cli/import/) for the top level package lock? We needed to do this for Simorgh on the call the other day, it may well be necessary for psammead too? I guess the others were regenerated by the existing tooling.
It seems you've wisely chosen to not remove lerna in this PR, I guess we may have a follow-up PR to either
- Remove lerna and replicate it's functionality using yarn's built in features
- Or investigate our existing issues with lerna and try and get local package linking working for example. A new version of lerna has appeared which gives us a bit more confidence in sticking with lerna: Lerna is largely unmaintained lerna/lerna#2703 (comment)

andrewscfc · 2021-02-11T08:04:08Z

scripts/check-package-manager.js

+const ensureYarn = () => {
+  // If npm is being run, print a message and cause 'npm install' to fail.
+  if (!process.env.npm_execpath.includes('yarn')) {
+    console.log(


Maybe add a lint ignore here to suppress this warning?

andrewscfc · 2021-02-11T08:04:52Z

scripts/enforceVersions.sh

    tput setaf 1
-    echo "\nOh no! You're not using our version of npm, please move to version $desired_npm_version in order to reduce bundling inconsistency"
+    echo "\nOh no! You're not using our version of yarn, please move to version $desired_yarn_version in order to reduce bundling inconsistency"


Did you do this on the Simorgh branch, I don't remember seeing it, the same script is in that repo too?

Yep this was in the original Simorgh PR

jroebu14 · 2021-02-11T08:18:27Z

@andrewscfc yeh I used yarn import && rm package-lock.json in the top level and then lerna exec -- yarn import && rm package-lock.json to do the same in every package.

Yeh this PR is just to use Yarn for installing dependencies and switching to Yarn commands. Anything else will be separate PRs.

chris-hinds · 2021-02-11T09:11:31Z

.github/workflows/psammead-publish.yml

@@ -22,10 +22,10 @@ jobs:
          scope: '@bbc'

      - name: Install Node Modules
-        run: npm run ci:packages
+        run: yarn run ci:packages


It's small and doesn't make much different but I think with yarn you can also remove the run command so just yarn ci:packages should work.

Not crucial to this work though.

Removed run from all yarn commands in this commit

chris-hinds · 2021-02-11T09:17:01Z

.github/workflows/psammead-change-scanner.yml

@@ -17,7 +17,7 @@ jobs:
          persist-credentials: false

      - name: Install Node Modules
-        run: npm run ci:packages
+        run: yarn run ci:packages


Looks like the SetupNode GH action comes preinstalled with yarn! Nice 👍

Bump package versions for psammead, psammead-amp-geo, psammead-brand, psammead-bulleted-list, psammead-bulletin, psammead-byline, psammead-caption, psammead-consent-banner, psammead-content-anchor, psammead-copyright, psammead-embed-error, psammead-episode-list, psammead-figure, psammead-grid, psammead-heading-index, psammead-headings, psammead-image-placeholder, psammead-image, psammead-inline-link, psammead-live-label, psammead-media-indicator, psammead-media-player, psammead-most-read, psammead-navigation, psammead-oembed, psammead-paragraph, psammead-play-button, psammead-podcast-promo, psammead-radio-schedule, psammead-script-link, psammead-section-label, psammead-sitewide-links, psammead-social-embed, psammead-story-promo-list, psammead-story-promo, psammead-timestamp, psammead-useful-links, psammead-visually-hidden-text, psammead-timestamp-container, gel-foundations, moment-timezone-include, psammead-assets, psammead-calendars, psammead-detokeniser, psammead-locales, psammead-rich-text-transforms, psammead-storybook-helpers, psammead-styles, psammead-test-helpers, web-vitals

Updates changelogs for psammead, psammead-amp-geo, psammead-brand, psammead-bulleted-list, psammead-bulletin, psammead-byline, psammead-caption, psammead-consent-banner, psammead-content-anchor, psammead-copyright, psammead-embed-error, psammead-episode-list, psammead-figure, psammead-grid, psammead-heading-index, psammead-headings, psammead-image-placeholder, psammead-image, psammead-inline-link, psammead-live-label, psammead-media-indicator, psammead-media-player, psammead-most-read, psammead-navigation, psammead-oembed, psammead-paragraph, psammead-play-button, psammead-podcast-promo, psammead-radio-schedule, psammead-script-link, psammead-section-label, psammead-sitewide-links, psammead-social-embed, psammead-story-promo-list, psammead-story-promo, psammead-timestamp, psammead-useful-links, psammead-visually-hidden-text, psammead-timestamp-container, gel-foundations, moment-timezone-include, psammead-assets, psammead-calendars, psammead-detokeniser, psammead-locales, psammead-rich-text-transforms, psammead-storybook-helpers, psammead-styles, psammead-test-helpers, web-vitals

…ew install

github-actions · 2021-02-19T10:54:25Z

Checkout your storybook preview here http://psammead-preview.tools.bbc.co.uk/4335

Jonathan Roebuck added 15 commits February 10, 2021 15:06

create yarn.lock using yarn import

9dc208b

update enforceVersions to use yarn

485864f

update package.json to use yarn commands

d08739f

update github actions to use yarn

0cb864b

update Talos to use yarn

2d3af33

update yeoman to use yarn

5a85f13

update docs to use yarn

91bebbd

yarn import to generate yarn.lock and rm package-lock.json

ac129af

update lerna config

d453b96

prevent npm installs. add doc on installing and using yarn

5d4267f

update shell scripts to use yarn

a70d37a

update talos to use yarn

a2d88d1

update readme.md

2494599

replace .npmrc with .yarnrc

33c5e21

use correct yarn flag --no-lockfile in lerna.json

089422c

jroebu14 added the cross-team For visibility for both World Service teams (Engage & Media) label Feb 10, 2021

jroebu14 self-assigned this Feb 10, 2021

andrewscfc reviewed Feb 11, 2021

View reviewed changes

fix preinstall script

a0105b5

ignore console.log warning

f69057d

chris-hinds approved these changes Feb 11, 2021

View reviewed changes

ryanmccombe approved these changes Feb 11, 2021

View reviewed changes

Jonathan Roebuck added 3 commits February 12, 2021 13:35

remove run from yarn commands

a335bd9

fix package bumping script

3382082

Merge branch 'latest' into migrate-to-yarn

f5b223d

jroebu14 marked this pull request as ready for review February 12, 2021 14:18

jroebu14 requested review from craigkj and jamesdonoh as code owners February 12, 2021 14:18

Jonathan Roebuck added 3 commits February 12, 2021 14:20

Merge branch 'latest' into migrate-to-yarn

7b09314

jroebu14 force-pushed the migrate-to-yarn branch from 041ef8f to 1764d24 Compare February 12, 2021 14:33

Jonathan Roebuck added 8 commits February 12, 2021 14:34

use yarn in storybook preview action

aeb8c63

add yarn ci script to remove invalid transitive dependencies before n…

01ce099

…ew install

merge latest

b89a06b

Merge branch 'latest' into migrate-to-yarn

4219f11

fix ci:packages script which uses lerne exec

31d0e9a

fix ci:packages not installing packages

43f54bd

fix bumpPackages unit test

39f2e0f

install all packages in storybook-preview GH action

94ca300

chris-hinds approved these changes Feb 19, 2021

View reviewed changes

jroebu14 merged commit 6507b48 into latest Feb 19, 2021

jroebu14 deleted the migrate-to-yarn branch February 19, 2021 11:48

simorgh-bbc mentioned this pull request Mar 5, 2021

Talos - Bump @bbc/psammead-radio-schedule #4422

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to yarn #4335

Migrate to yarn #4335

jroebu14 commented Feb 10, 2021 •

edited

Loading

andrewscfc left a comment

andrewscfc Feb 11, 2021

andrewscfc Feb 11, 2021

jroebu14 Feb 11, 2021

jroebu14 commented Feb 11, 2021

chris-hinds Feb 11, 2021

jroebu14 Feb 12, 2021

chris-hinds Feb 11, 2021

github-actions bot commented Feb 19, 2021

Migrate to yarn #4335

Migrate to yarn #4335

Conversation

jroebu14 commented Feb 10, 2021 • edited Loading

andrewscfc left a comment

Choose a reason for hiding this comment

andrewscfc Feb 11, 2021

Choose a reason for hiding this comment

andrewscfc Feb 11, 2021

Choose a reason for hiding this comment

jroebu14 Feb 11, 2021

Choose a reason for hiding this comment

jroebu14 commented Feb 11, 2021

chris-hinds Feb 11, 2021

Choose a reason for hiding this comment

jroebu14 Feb 12, 2021

Choose a reason for hiding this comment

chris-hinds Feb 11, 2021

Choose a reason for hiding this comment

github-actions bot commented Feb 19, 2021

jroebu14 commented Feb 10, 2021 •

edited

Loading