Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Replace instances of BBC Nassim with BBC Reith Qalam #4002

Merged
merged 15 commits into from
Nov 23, 2020
Merged

Replace instances of BBC Nassim with BBC Reith Qalam #4002

merged 15 commits into from
Nov 23, 2020

Conversation

simonsinclair
Copy link
Contributor

No issue.

Overall change:

This PR updates psammead-styles and replaces instances of BBC Nassim with BBC Reith Qalam.

Code changes:

  • Add BBC Reith Qalam font-face rules
  • Remove BBC Nassim font-face rules
  • Apply BBC Reith Qalam to services previously using BBC Nassim
  • Update relevant snapshots
  • Bump major package version
  • Add changelog entry
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@simonsinclair simonsinclair added the ws-articles Tasks for the WS Articles Team label Nov 18, 2020
@simonsinclair simonsinclair self-assigned this Nov 18, 2020
@simonsinclair simonsinclair changed the title Replace BBC Nassim with BBC Reith Qalam Replace instances of BBC Nassim with BBC Reith Qalam Nov 18, 2020
karinathomasbbc
karinathomasbbc reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update gel-foundations before we do this - the font heights & weights need to be updated?

packages/utilities/psammead-styles/src/font-families.js Show resolved Hide resolved
packages/utilities/psammead-styles/CHANGELOG.md Outdated Show resolved Hide resolved
@simonsinclair
Copy link
Contributor Author

simonsinclair commented Nov 18, 2020 •
edited
Loading

Do we need to update gel-foundations before we do this - the font heights & weights need to be updated?

gel-foundations can be updated following these changes (or after) - neither packages depend on one another. They will be released as major versions, which will require someone to willingly install them.

@simonsinclair simonsinclair merged commit f246f3b into latest Nov 23, 2020
@simonsinclair simonsinclair deleted the qalam-styles branch November 23, 2020 15:09
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Nov 23, 2020
Merged
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Nov 26, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

@andrewscfc andrewscfc andrewscfc approved these changes

Assignees

@simonsinclair simonsinclair

Labels
ws-articles Tasks for the WS Articles Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonsinclair @andrewscfc @karinathomasbbc