Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Emotion 'styled-components' mentions cleanup #3927

Merged
merged 26 commits into from
Oct 19, 2020
Merged

Emotion 'styled-components' mentions cleanup #3927

merged 26 commits into from
Oct 19, 2020

Conversation

RichardPK
Copy link
Contributor

@RichardPK RichardPK commented Oct 19, 2020 •
edited by simonsinclair
Loading

Resolves #NUMBER

Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@RichardPK RichardPK self-assigned this Oct 19, 2020
simonsinclair
simonsinclair approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@simonsinclair simonsinclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - maybe we should make the style-lint change more apparent in the changelog? 👍

packages/components/psammead-navigation/CHANGELOG.md Outdated Show resolved Hide resolved
@simonsinclair simonsinclair added cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features labels Oct 19, 2020
@simonsinclair simonsinclair added this to the Migrate to Emotion milestone Oct 19, 2020
@RichardPK RichardPK merged commit 9efdc21 into latest Oct 19, 2020
@simonsinclair simonsinclair deleted the emotion-mentions-cleanup branch October 19, 2020 14:03
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Oct 19, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanmccombe ryanmccombe ryanmccombe approved these changes

@simonsinclair simonsinclair simonsinclair approved these changes

Assignees

@RichardPK RichardPK

Labels
cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Milestone
Migrate to Emotion
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardPK @simonsinclair @ryanmccombe