Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Styled components cleanup #3923

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Styled components cleanup #3923

merged 4 commits into from
Oct 19, 2020

Conversation

ryanmccombe
Copy link
Contributor

Resolves #NUMBER

Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@ryanmccombe ryanmccombe changed the base branch from latest to emotion-radio-schedule October 19, 2020 10:49
@ryanmccombe ryanmccombe merged commit da00556 into emotion-radio-schedule Oct 19, 2020
@simonsinclair simonsinclair deleted the styled-components-cleanup-a branch October 19, 2020 10:55
@simonsinclair simonsinclair added this to the Migrate to Emotion milestone Oct 19, 2020
@simonsinclair simonsinclair added cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features labels Oct 19, 2020
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Oct 19, 2020
Merged
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Nov 26, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RichardPK RichardPK RichardPK approved these changes

@simonsinclair simonsinclair simonsinclair approved these changes

Assignees

@ryanmccombe ryanmccombe

Labels
cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Milestone
Migrate to Emotion
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanmccombe @simonsinclair @RichardPK