Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

[Level 4] Migrate psammead-navigation #3900

Merged
merged 9 commits into from
Oct 16, 2020
Merged

[Level 4] Migrate psammead-navigation #3900

merged 9 commits into from
Oct 16, 2020

Conversation

simonsinclair
Copy link
Contributor

@simonsinclair simonsinclair commented Oct 16, 2020 •
edited
Loading

Resolves #NUMBER

Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@simonsinclair simonsinclair added technical-work Technical debt, support work and building new technical tools and features cross-team For visibility for both World Service teams (Engage & Media) labels Oct 16, 2020
@simonsinclair simonsinclair added this to the Migrate to Emotion milestone Oct 16, 2020
@simonsinclair simonsinclair self-assigned this Oct 16, 2020
@RichardPK RichardPK changed the base branch from latest to migrate-figure-emotion October 16, 2020 15:51
@simonsinclair simonsinclair merged commit f6d460a into migrate-figure-emotion Oct 16, 2020
@simonsinclair simonsinclair deleted the migrate-psammead-navigation branch October 16, 2020 15:56
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Oct 16, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RichardPK RichardPK RichardPK approved these changes

@ryanmccombe ryanmccombe ryanmccombe approved these changes

Assignees

@simonsinclair simonsinclair

Labels
cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Milestone
Migrate to Emotion
Development

Successfully merging this pull request may close these issues.
3 participants
@simonsinclair @ryanmccombe @RichardPK