Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Storybook updates to support Reith Qalam #3832

Merged
merged 8 commits into from
Oct 7, 2020

Conversation

karinathomasbbc
Copy link
Contributor

@karinathomasbbc karinathomasbbc commented Oct 6, 2020

Resolves #3800

Overall change:
Upgrade gel-foundations library to use Reith Qalam font

Code changes:

  • Add Reith Qalam fonts to Storybook static assets
  • package, package-lock & changelog updates

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@karinathomasbbc karinathomasbbc added the ws-articles Tasks for the WS Articles Team label Oct 6, 2020
@karinathomasbbc karinathomasbbc added this to the BBC Reith Qalam Font milestone Oct 6, 2020
@karinathomasbbc karinathomasbbc self-assigned this Oct 6, 2020
@karinathomasbbc karinathomasbbc changed the title Upgrade gel-foundations to 5.0.0 Upgrade Storybook dependency on @bbc/gel-foundations to 5.0.0 Oct 6, 2020
@karinathomasbbc karinathomasbbc changed the title Upgrade Storybook dependency on @bbc/gel-foundations to 5.0.0 Storybook updates to support Reith Qalam Oct 6, 2020
Copy link
Contributor

@simonsinclair simonsinclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we unable to use the hosted version of these fonts? My concern is that they get updated over time, especially during the release stages, and we might be duplicating effort hosting them in multiple places.

Edit:
I can see there is already logic in place to use all web fonts locally, so this is probably not one for this PR.

@karinathomasbbc
Copy link
Contributor Author

Are we unable to use the hosted version of these fonts? My concern is that they get updated over time, especially during the release stages, and we might be duplicating effort hosting them in multiple places.

Edit:
I can see there is already logic in place to use all web fonts locally, so this is probably not one for this PR.

Yeah I agree with you - this is not ideal. I will raise an issue to address this - the same could be said for all of those fonts - it't not ideal having them in multiple places.

Copy link
Contributor

@FK78 FK78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Reith Qalam font typography
3 participants