Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Support for BBC Reith Qalam - font & font family #3804

Merged
merged 28 commits into from
Oct 7, 2020
Merged

Support for BBC Reith Qalam - font & font family #3804

merged 28 commits into from
Oct 7, 2020

Conversation

karinathomasbbc
Copy link
Contributor

@karinathomasbbc karinathomasbbc commented Sep 29, 2020 •
edited
Loading

Resolves #3802

Overall change:
Adding the font and font family for BBC Reith Qalam

Code changes:

  • Adding BBC Reith Qalam fonts for Arabic, Pashto, Persian and Urdu
  • Removal of BBC Nassim fonts for Arabic, Pashto, Persian and Urdu
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@karinathomasbbc karinathomasbbc added the ws-articles Tasks for the WS Articles Team label Sep 29, 2020
@karinathomasbbc karinathomasbbc added this to the BBC Reith Qalam Font milestone Sep 29, 2020
@karinathomasbbc karinathomasbbc self-assigned this Sep 29, 2020
@karinathomasbbc karinathomasbbc changed the base branch from latest to 3310-IE-high-contrast-mode-bug October 5, 2020 13:00
@karinathomasbbc karinathomasbbc changed the base branch from 3310-IE-high-contrast-mode-bug to latest October 5, 2020 13:00
simonsinclair
simonsinclair approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@simonsinclair simonsinclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super, Karina. 👍

packages/utilities/psammead-styles/src/__snapshots__/fonts.test.js.snap Show resolved Hide resolved
@karinathomasbbc karinathomasbbc merged commit 9513667 into latest Oct 7, 2020
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Oct 7, 2020
Merged
@karinathomasbbc karinathomasbbc deleted the bbc-reith-qalam-font branch October 7, 2020 13:37
@simonsinclair simonsinclair mentioned this pull request Oct 12, 2020
Merged
3 tasks
This was referenced Aug 27, 2021
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonsinclair simonsinclair simonsinclair approved these changes

@rhenshaw56 rhenshaw56 rhenshaw56 approved these changes

Assignees

@karinathomasbbc karinathomasbbc

Labels
ws-articles Tasks for the WS Articles Team
Projects
None yet
Milestone
BBC Reith Qalam Font
Development

Successfully merging this pull request may close these issues.

Add Reith Qalam font & font family
3 participants
@karinathomasbbc @simonsinclair @rhenshaw56