This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Update top-level Story-Promo, Grid and Media Indicator #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
commented
Feb 10, 2020
DenisHdz
approved these changes
Feb 10, 2020
thekp
approved these changes
Feb 10, 2020
|
Top story layout looks a bit wrong: https://www.chromaticqa.com/snapshot?appId=5d28eb5ee163f6002046d6fb&id=5e42743e719fc800226c2865 |
… use-latest-story-promo
|
Looking as expected now https://www.chromaticqa.com/snapshot?appId=5d28eb5ee163f6002046d6fb&id=5e42906f878b650022249572 |
thekp
approved these changes
Feb 11, 2020
|
Looks good to me.Can be merged. |
DenisHdz
changed the title
This was referenced Mar 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ticket - updating dependencies
Overall change:
Use
@bbc/[email protected],@bbc/[email protected]and@bbc/[email protected]Code changes:
package.jsondirprop to Grid stories and Media Indicator used in Story PromoAs a result of this update, the stories that include story-promo have been updated:
http://localhost:8180/?path=/story/components-grid--example-with-top-story-and-regular-promos