Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add and export KINGFISHER colour #2943

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Add and export KINGFISHER colour #2943

merged 3 commits into from
Jan 16, 2020

Conversation

EinsteinNjoroge
Copy link
Contributor

@EinsteinNjoroge EinsteinNjoroge commented Jan 16, 2020 •
edited
Loading

Resolves #2942

Overall change: Add and export the colour #11708C as C_KINGFISHER in psammead-styles.

Code changes:

  • Add and export the colour #11708C as C_KINGFISHER in psammead-styles.
  • Update snapshots.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@EinsteinNjoroge EinsteinNjoroge self-assigned this Jan 16, 2020
@EinsteinNjoroge EinsteinNjoroge added radio-schedules ws-home Tasks for the WS Home Team labels Jan 16, 2020
@EinsteinNjoroge EinsteinNjoroge marked this pull request as ready for review January 16, 2020 10:40
j-pendlebury
j-pendlebury approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@j-pendlebury j-pendlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EinsteinNjoroge EinsteinNjoroge merged commit 48287c0 into latest Jan 16, 2020
@EinsteinNjoroge EinsteinNjoroge deleted the export-kingfisher-colour branch January 16, 2020 11:16
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Jan 20, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FK78 FK78 FK78 approved these changes

@j-pendlebury j-pendlebury j-pendlebury approved these changes

@mmcculloch mmcculloch mmcculloch approved these changes

Assignees

@EinsteinNjoroge EinsteinNjoroge

Labels
radio-schedules ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add KINGFISHER to psammead-styles color
4 participants
@EinsteinNjoroge @mmcculloch @j-pendlebury @FK78