This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Move media query hooks to Simorgh #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlistairGempf
requested review from
jamesbhobbs,
craigkj,
DenisHdz,
j-pendlebury,
jroebu14 and
sareh
as code owners
tochwill
approved these changes
Dec 9, 2019
DenisHdz
reviewed
Dec 10, 2019
Comment on lines
155
to
157
| mediaQueryList.addListener(event => { | ||
| setIsScrollable(event.matches); | ||
| }); |
There was a problem hiding this comment.
With this refactor we don't have the removeListener method anymore.
const handler = event => setMatches(event.matches);
mediaQueryList.addListener(handler);
return () => mediaQueryList.removeListener(handler);
There was a problem hiding this comment.
Good point, I'll add this back in for the story to prevent the storybook slowing down due to there being a load of extra listeners that aren't being used anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change: Remove the media query hook so that it can be added in simorgh to allow for other actions to be triggered on a media query.
Code changes:
isScrollableprop to be set in Simorgh based on the media query hook