This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Fix nav menu border in High Contrast #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaLyubin
requested review from
jamesbhobbs,
craigkj,
DenisHdz,
j-pendlebury,
jroebu14 and
sareh
as code owners
DenisHdz
reviewed
Dec 5, 2019
packages/components/psammead-navigation/src/DropdownNavigation/index.jsx
Outdated
Show resolved
Hide resolved
tochwill
approved these changes
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2774
Overall change:
Borders and icon are now properly located on a button and do not get shifted in High Contrast mode on FireFox.
Code changes:
The problem before was that (only in FF HC mode) a border appeared which was not supposed to be there. Rearranging the styling fixed the issue.