This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Use a react button to spread styled-component props #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlistairGempf
requested review from
jamesbhobbs,
craigkj,
DenisHdz,
j-pendlebury,
jroebu14 and
sareh
as code owners
tochwill
approved these changes
Dec 4, 2019
ghost
reviewed
Dec 5, 2019
packages/components/psammead-navigation/src/DropdownNavigation/index.jsx
Show resolved
Hide resolved
DenisHdz
approved these changes
Dec 5, 2019
ghost
approved these changes
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change: Use a react button to spread styled-component props, preventing styled-components from filtering it out as a non-standard attribute. This is required for the
onattribute required for the Amp Menu Button. For some reason this only happens on the SSR though, so it doesn't show up as missing on any of the tests or storybook, only once we try and pull it into Simorgh.Code changes: