This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add prop isOpen to Navigation
#2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bopchy
requested review from
jamesbhobbs,
craigkj,
DenisHdz,
j-pendlebury,
jroebu14 and
sareh
as code owners
added 2 commits
December 4, 2019 17:18
|
How do i view this change? |
|
Currently this is not viewable in Psammead as the colour of the Navigation should change when the Dropdown is open - and the components have been put together in Simorgh. This is what the Navigation currently looks like when the menu is open |
Bopchy
changed the title
isOpen to Navigation
|
Renamed the PR to reflect the changes it is adding better |
OlgaLyubin
reviewed
Dec 4, 2019
ghost
reviewed
Dec 4, 2019
Co-Authored-By: Olha Lyubinets <[email protected]> Co-Authored-By: sadickisaac <[email protected]>
…ammead into change-nav-colour-on-menu-opening
ghost
reviewed
Dec 4, 2019
oluoluoxenfree
approved these changes
Dec 4, 2019
|
Added a snapshot test. |
AlistairGempf
approved these changes
Dec 4, 2019
ghost
reviewed
Dec 5, 2019
ghost
approved these changes
Dec 5, 2019
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change: Adds a prop
isOpenthat if true, changes the background colour of the Navigation from C_POSTBOX to C_EBON.Code changes:
isOpenprop.