-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
So... Working with @radiocontrolled, we observed that when the previous However, removing the As such, we have removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great investigation work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re:
Following this issue, when pulling in latest & wanting to resolve package-lock differences, run npm run install:packages. There is an equivalent package-lock-only command: npm run ci:packages.
Could we document this in the readme as it will be a recurring 'gotcha'?
This looks to be working having removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🎆
LGTM 👍 |
Resolves #263
Fixing the out of sync
package-lock.json
on latest was made more difficult by thepsammead-test-helpers
issue -- Many of the nested packages hadpackage-lock.json
files which seemed to be pointing to0.1.3
, a version not present on NPM.Following this issue, when pulling in latest & wanting to resolve package-lock differences, run
npm run install:packages
. There is an equivalent package-lock-only command:npm run ci:packages
.