This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Remove input provider and with dir #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sammead into remove-input-provider-and-with-dir
jroebu14
requested review from
jamesbhobbs,
dr3,
j-pendlebury and
sareh
as code owners
added 7 commits
October 16, 2019 15:18
…sammead into remove-input-provider-and-with-dir
thekp
reviewed
Oct 17, 2019
There was a problem hiding this comment.
looks like you have to update each package.json/package-lock/changelog for the psammead packages you've updated: https://ci.news.tools.bbc.co.uk/blue/organizations/jenkins/psammead/detail/remove-input-provider-and-with-dir/16/pipeline
😿
Bump package versions for psammead-brand, psammead-caption, psammead-consent-banner, psammead-figure, psammead-grid, psammead-headings, psammead-inline-link, psammead-media-indicator, psammead-navigation, psammead-paragraph, psammead-play-button, psammead-script-link, psammead-section-label, psammead-sitewide-links, psammead-story-promo, psammead-timestamp, psammead-useful-links, psammead-visually-hidden-text, psammead-timestamp-container, psammead-storybook-helpers, psammead-storybook-helpers, psammead-storybook-helpers, psammead-storybook-helpers, psammead-storybook-helpers, psammead-styles
Updates changelogs for psammead-brand, psammead-caption, psammead-consent-banner, psammead-figure, psammead-grid, psammead-headings, psammead-inline-link, psammead-media-indicator, psammead-navigation, psammead-paragraph, psammead-play-button, psammead-script-link, psammead-section-label, psammead-sitewide-links, psammead-story-promo, psammead-timestamp, psammead-useful-links, psammead-visually-hidden-text, psammead-timestamp-container, psammead-storybook-helpers, psammead-storybook-helpers, psammead-storybook-helpers, psammead-storybook-helpers, psammead-storybook-helpers, psammead-styles
|
@thekp oh yeh. so easy with the package bumping script! |
chris-hinds
approved these changes
Oct 17, 2019
thekp
approved these changes
Oct 17, 2019
thekp
reviewed
Oct 17, 2019
packages/components/psammead-section-label/src/index.stories.jsx
Outdated
Show resolved
Hide resolved
|
@thekp good call. no we don't. I can create these just now. |
1 task
thekp
approved these changes
Oct 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2371
Overall change: Removes deprecated psammead test helpers
dirDecoratorandinputProviderin favour ofwithServicesKnobdecorator.Code changes:
dirDecoratorandinputProviderwithwithServicesKnobdirDecoratorandinputProviderfromREADME.md