This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Spread extra props in components. #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates changelogs for psammead-brand, psammead-navigation, psammead-section-label, psammead-story-promo
ghost
self-assigned this
ghost
marked this pull request as ready for review
ghost
requested review from
jamesbhobbs,
dr3,
j-pendlebury,
jroebu14 and
sareh
as code owners
dr3
reviewed
Oct 11, 2019
dr3
reviewed
Oct 11, 2019
dr3
reviewed
Oct 11, 2019
ghost
mentioned this pull request
3 tasks
|
Just noticed that packages with breaking changes are being bumped to new minor versions - if following semver should these be major versions? |
Done :) |
tochwill
approved these changes
Oct 15, 2019
12
reviewed
Oct 16, 2019
| @@ -3,6 +3,7 @@ | |||
| <!-- prettier-ignore --> | |||
| | Version | Description | | |||
| | ------- | ----------- | | |||
| | 5.0.6 | [PR#2377](https://github.com/bbc/psammead/pull/2377) Spread extra props to the component | | |||
There was a problem hiding this comment.
Should this be a breaking change as well, considering the others are?
There was a problem hiding this comment.
The patch should be fine since we are not removing props as in the others.
ryanmccombe
approved these changes
Oct 16, 2019
dr3
approved these changes
Oct 16, 2019
1 task
This was referenced Oct 17, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2376
Overall change: Spread extra props to component to keep simorgh logic on event tracking out of psammead.
Code changes:
data-*attributes to be passed in simorgh.SectionLabelNavigationLiBrandStoryPromo