This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbc-news-frameworks
requested review from
jamesbhobbs,
dr3,
j-pendlebury,
jroebu14 and
sareh
as code owners
September 30, 2019 12:38
j-pendlebury
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me π thank you for the fixes
ghost
approved these changes
Oct 1, 2019
This was referenced Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π The following packages have been updated:
@bbc/psammead
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-inline-link
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-consent-banner
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-brand
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-headings
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-copyright
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-timestamp
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-image-placeholder
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-caption
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-story-promo
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-sitewide-links
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-media-indicator
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-navigation
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-section-label
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-paragraph
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0@bbc/psammead-story-promo-list
Details
@bbc/psammead-styles ^3.0.0 β ^4.0.0