Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Create locales for Hausa and Somali #2196

Merged
merged 8 commits into from
Sep 20, 2019
Merged

Create locales for Hausa and Somali #2196

merged 8 commits into from
Sep 20, 2019

Conversation

DenisHdz
Copy link
Contributor

Resolves #2171

Overall change:
Add moment locales for Hausa (ha) and Somali (so).

Code changes:

  • Add locale files with months and relative time
  • Add unit tests.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DenisHdz DenisHdz added the ws-home Tasks for the WS Home Team label Sep 20, 2019
@DenisHdz DenisHdz self-assigned this Sep 20, 2019
@DenisHdz DenisHdz mentioned this pull request Sep 20, 2019
Closed
1 task
AlistairGempf
AlistairGempf approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@AlistairGempf AlistairGempf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good other than the typo.

@DenisHdz DenisHdz requested a review from a user September 20, 2019 10:02
@staylos92 staylos92 self-assigned this Sep 20, 2019
@staylos92
Copy link
Contributor

LGTM 👍

@DenisHdz DenisHdz merged commit f829d60 into latest Sep 20, 2019
@DenisHdz DenisHdz deleted the create-moment-hausa-somali branch September 20, 2019 11:08
This was referenced Sep 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlistairGempf AlistairGempf AlistairGempf approved these changes

@j-pendlebury j-pendlebury j-pendlebury approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@dr3 dr3 Awaiting requested review from dr3

@jroebu14 jroebu14 Awaiting requested review from jroebu14

@sareh sareh Awaiting requested review from sareh

Assignees

@staylos92 staylos92

@DenisHdz DenisHdz

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create moment locale for - Hausa, Somali
4 participants
@DenisHdz @staylos92 @j-pendlebury @AlistairGempf