Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Create locales for Gahuza and Tigrinya #2193

Merged
merged 20 commits into from
Sep 20, 2019
Merged

Conversation

DenisHdz
Copy link
Contributor

@DenisHdz DenisHdz commented Sep 20, 2019

Resolves #2180

Overall change:
Add moment locales for Gahuza (rw) and Tigrinya (ti).

Code changes:

  • Add locale files with months and relative time
  • Add unit tests.

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DenisHdz DenisHdz added the ws-home Tasks for the WS Home Team label Sep 20, 2019
@DenisHdz DenisHdz self-assigned this Sep 20, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the correct locale for Gahuza in storybook

@DenisHdz DenisHdz requested a review from a user September 20, 2019 07:53
@DenisHdz DenisHdz mentioned this pull request Sep 20, 2019
1 task
@ghost
Copy link

ghost commented Sep 20, 2019

Could you check why Jenkins is failing.

@AlistairGempf
Copy link
Contributor

Is there a reason for the Tigrinya locale being named yi rather than ti as it is in the spreadsheet and in the language data?

@DenisHdz
Copy link
Contributor Author

DenisHdz commented Sep 20, 2019

Is there a reason for the Tigrinya locale being named yi rather than ti as it is in the spreadsheet and in the language data?

You are right, I have created it based on what the issue says. In the moment-ws repo we have ti.
@sadick254 Was it a typo? 😁

Copy link
Contributor

@AlistairGempf AlistairGempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a cmd-f for yi and found nothing so I think we're all good ;)

@staylos92
Copy link
Contributor

LGTM 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create moment locale for - Gahuza, Tigrinya
4 participants