Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Simplifies stories #2181

Merged
merged 10 commits into from
Sep 20, 2019
Merged

Simplifies stories #2181

merged 10 commits into from
Sep 20, 2019

Conversation

samora
Copy link
Contributor

@samora samora commented Sep 19, 2019 •
edited
Loading

Resolves #2157

Overall change: Simplifies stories. Remove dependencies which are not important to demonstrating usage.

Code changes:

  • Remove story promo's dependency on Timestamp.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@samora samora requested a review from dr3 September 19, 2019 05:08
sareh
sareh reviewed Sep 20, 2019
View reviewed changes
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please also update the version in the package.json, package-lock.json and Changelog. A patch version increase would be good.

pharingee
pharingee approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@pharingee pharingee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sareh
sareh approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@samora samora self-assigned this Sep 20, 2019
@samora samora added ws-articles Tasks for the WS Articles Team discussion shared-components labels Sep 20, 2019
FK78
FK78 approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@FK78 FK78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sareh sareh merged commit 920cfa1 into latest Sep 20, 2019
@sareh sareh deleted the simplify-stories branch September 20, 2019 10:34
This was referenced Sep 20, 2019
Closed
Merged
This was referenced Oct 3, 2019
Closed
Closed
@pharingee pharingee mentioned this pull request Oct 15, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FK78 FK78 FK78 approved these changes

@thekp thekp thekp approved these changes

@dr3 dr3 dr3 approved these changes

@pharingee pharingee pharingee approved these changes

@sareh sareh sareh approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@jroebu14 jroebu14 Awaiting requested review from jroebu14

Assignees

@samora samora

Labels
discussion shared-components ws-articles Tasks for the WS Articles Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop building complex stories in psammead packages
6 participants
@samora @sareh @pharingee @dr3 @thekp @FK78