This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Override default moment relative time - Arabic, Brasil and Mundo #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisHdz
requested review from
jamesbhobbs,
dr3,
j-pendlebury,
jroebu14 and
sareh
as code owners
…amp-translations-arabic-brasil-mundo
ghost
approved these changes
Sep 19, 2019
…amp-translations-arabic-brasil-mundo
DenisHdz
changed the title
DenisHdz
changed the title
AlistairGempf
approved these changes
Sep 19, 2019
sareh
reviewed
Sep 19, 2019
sareh
reviewed
Sep 19, 2019
… github.com:bbc/psammead into relative-timestamp-translations-arabic-brasil-mundo
sareh
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
👍 Looks good!
When reviewing the Arabic locale, it was difficult to use the snapshots from Storybook since the Arabic text is left-aligned and that means a mix of digits 0-9 and Arabic words mess up the word order. We should update the stories for Moment locales to have the dir={dir} prop on the localised text.
dr3
approved these changes
Sep 20, 2019
… github.com:bbc/psammead into relative-timestamp-translations-arabic-brasil-mundo
|
Looks good to me.. |
DenisHdz
deleted the
relative-timestamp-translations-arabic-brasil-mundo
branch
This was referenced Sep 23, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2151
Overall change:
Override default moment relative time so that we can have the correct localized relative time.
Code changes:
eslocale for Mundoar(Arabic) andpt-br(Brasil)