This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add exports for scripts #2169
Merged
Add exports for scripts #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
requested review from
jamesbhobbs,
dr3,
j-pendlebury and
jroebu14
as code owners
sareh
commented
Sep 17, 2019
DenisHdz
reviewed
Sep 17, 2019
|
|
||
| export latinDiacritics from './scripts/latin-with-diacritics'; | ||
|
|
||
| export chinese from './scripts/no-ascenders-or-descenders'; |
There was a problem hiding this comment.
Initially, we decided to have this mapping, but at this point, should we still export several times the same script? E.g. chinese, ethiopic and korean?
There was a problem hiding this comment.
@DenisHdz I'm going to remove the services names as exports from this gel-foundations in a future PR. But for now, I'm ensuring we are exporting the script values. This is so that I can use the scripts latinDiacritics and noAscendersOrDescenders etc in Simorgh, then removal of the service exports will not cause any issues.
There was a problem hiding this comment.
It makes sense to me, thanks :)
jroebu14
approved these changes
Sep 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves bbc/simorgh#3837
Overall change: Add exports for scripts devanagariAndGurmukhi, noAscendersOrDescenders & cyrillicAndLatin
Code changes:
@bbc/gel-foundations/scripts:devanagariAndGurmukhi,noAscendersOrDescenders&cyrillicAndLatin