Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Consistent use of destructuring props #1938

Merged
merged 9 commits into from
Aug 30, 2019
Merged

Consistent use of destructuring props #1938

merged 9 commits into from
Aug 30, 2019

Conversation

DenisHdz
Copy link
Contributor

@DenisHdz DenisHdz commented Aug 29, 2019 •
edited
Loading

Resolves #1921

Overall change:
Destructure props passed to styled components consistenly accross Psammead packages.

Code changes:

  • Desctrucuture props where we have props.script

    • psammead-caption
    • psammead-consent-banner
    • psammead-headings
    • psammead-navigation
    • psammead-paragraph
    • psammead-story-promo
    • psammead-timestamp

  • Update snapshots

  • Bump versions

  • I have assigned myself to this PR and the corresponding issues
  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DenisHdz DenisHdz added the ws-home Tasks for the WS Home Team label Aug 29, 2019
@DenisHdz DenisHdz self-assigned this Aug 29, 2019
@andrew-nowak andrew-nowak added ws-articles Tasks for the WS Articles Team shared-components simorgh-core-stream ws-media The World Service media stream labels Aug 29, 2019
@andrew-nowak
Copy link
Contributor

Adding a bunch of other pod labels because this isn't just front page components

jroebu14
jroebu14 approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@jroebu14 jroebu14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the snapshots I'm fairly confident the front end won't have changed 👍

andrew-nowak
andrew-nowak reviewed Aug 29, 2019
View reviewed changes
Copy link
Contributor

@andrew-nowak andrew-nowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a question that's possibly out of scope

packages/components/psammead-caption/src/index.jsx Show resolved Hide resolved
@staylos92
Copy link
Contributor

LGTM 👍

@staylos92 staylos92 self-assigned this Aug 29, 2019
@DenisHdz DenisHdz merged commit 17e2b98 into latest Aug 30, 2019
@DenisHdz DenisHdz deleted the destructure-props branch August 30, 2019 07:38
This was referenced Oct 3, 2019
Closed
Closed
This was referenced Oct 15, 2019
Closed
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrew-nowak andrew-nowak andrew-nowak left review comments

@dr3 dr3 dr3 approved these changes

@jroebu14 jroebu14 jroebu14 approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@sareh sareh Awaiting requested review from sareh

Assignees

@staylos92 staylos92

@DenisHdz DenisHdz

Labels
shared-components simorgh-core-stream ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team ws-media The World Service media stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent use of destructuring props
5 participants
@DenisHdz @andrew-nowak @staylos92 @jroebu14 @dr3