This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Talos - Bump @bbc/psammead-amp-geo, @bbc/psammead-brand, @bbc/psammead-caption, @bbc/psammead-consent-banner, @bbc/psammead-copyright, @bbc/psammead-figure, @bbc/psammead-headings, @bbc/psammead-image-placeholder, @bbc/psammead-image, @bbc/psammead-inline-link, @bbc/psammead-media-indicator, @bbc/psammead-navigation, @bbc/psammead-paragraph, @bbc/psammead-section-label, @bbc/psammead-sitewide-links, @bbc/psammead-story-promo-list, @bbc/psammead-story-promo, @bbc/psammead-timestamp, @bbc/psammead-visually-hidden-text, @bbc/psammead-timestamp-container, @bbc/gel-foundations, @bbc/moment-timezone-include, @bbc/psammead-assets, @bbc/psammead-locales, @bbc/psammead-storybook-helpers, @bbc/psammead-styles, @bbc/psammead-test-helpers #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbc-news-frameworks
requested review from
dr3,
j-pendlebury,
pjlee11 and
sareh
as code owners
jamesbhobbs
approved these changes
Aug 18, 2019
dr3
approved these changes
Aug 18, 2019
|
Need to confirm what changes this pulls in before deciding if this needs testing or not |
|
Given that there were zero test failures, snapshot updates and visual regression changes, I can't see what could need testing. |
|
sure, yolo |
This was referenced Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 The following packages have been published:
@bbc/psammead-amp-geo
@bbc/psammead-brand
@bbc/psammead-caption
@bbc/psammead-consent-banner
@bbc/psammead-copyright
@bbc/psammead-figure
@bbc/psammead-headings
@bbc/psammead-image-placeholder
@bbc/psammead-image
@bbc/psammead-inline-link
@bbc/psammead-media-indicator
@bbc/psammead-navigation
@bbc/psammead-paragraph
@bbc/psammead-section-label
@bbc/psammead-sitewide-links
@bbc/psammead-story-promo-list
@bbc/psammead-story-promo
@bbc/psammead-timestamp
@bbc/psammead-visually-hidden-text
@bbc/psammead-timestamp-container
@bbc/gel-foundations
@bbc/moment-timezone-include
@bbc/psammead-assets
@bbc/psammead-locales
@bbc/psammead-storybook-helpers
@bbc/psammead-styles
@bbc/psammead-test-helpers
So we need to bump them in the following packages:
@bbc/psammead-timestamp
@bbc/psammead-timestamp-container
@bbc/psammead-storybook-helpers
@bbc/psammead-consent-banner
@bbc/psammead-section-label
@bbc/psammead-navigation
@bbc/psammead-media-indicator
@bbc/psammead-image-placeholder
@bbc/psammead-inline-link
@bbc/psammead-copyright
@bbc/psammead-story-promo-list
@bbc/psammead-sitewide-links
@bbc/psammead-brand
@bbc/psammead-figure
@bbc/psammead-headings
@bbc/psammead-caption
@bbc/psammead-story-promo
@bbc/psammead-paragraph