This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Talos - Bump @bbc/psammead-styles #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbc-news-frameworks
requested review from
dr3,
j-pendlebury,
pjlee11 and
sareh
as code owners
|
This may need to wait for talos to be merged, so this PR can become based off of latest |
thekp
approved these changes
Aug 14, 2019
dr3
changed the base branch from
BumperBotIntegrate-new-new-new-new-new
to
latest
|
Changes that were bumped here in this PR have been UX reviewed.
|
|
Update to sitewide links to use the new Thai typography settings: Thai SitewideLinks Font size 14px, line height 18px Thai Media indicator text has font-size 12px, line height 16px. |
This was referenced Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 The following packages have been published:
@bbc/psammead-styles
So we need to bump them in the following packages:
@bbc/psammead-consent-banner
@bbc/psammead-copyright
@bbc/psammead-image-placeholder
@bbc/psammead-headings
@bbc/psammead-navigation
@bbc/psammead-sitewide-links
@bbc/psammead-brand
@bbc/psammead-paragraph
@bbc/psammead-caption
@bbc/psammead-story-promo-list
@bbc/psammead-inline-link
@bbc/psammead-story-promo
@bbc/psammead-media-indicator
@bbc/psammead-timestamp
@bbc/psammead-section-label
Testing note added by @sareh:
@bbc/[email protected]fixed the font base url for Latha (used by the Tamil service) and so it should be bumped up through all of these packages, so that in our consuming application Simorgh, we don't have multiple versions of psammead-styles.Also updated to include bumps to these packages:
The following package has been published:
@bbc/gel-foundations
So we need to bump them in the following packages:
psammead-brand
psammead-caption
psammead-consent-banner
psammead-copyright
psammead-headings
psammead-media-indicator
psammead-navigation
psammead-paragraph
psammead-section-label
psammead-sitewide-links
psammead-story-promo-list
psammead-story-promo
psammead-timestamp
psammead-storybook-helpers