This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Move dev dep to top level #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekp
added
simorgh-core-stream
dependencies
thekp
requested review from
dr3,
j-pendlebury,
pjlee11 and
sareh
as code owners
jamesbhobbs
approved these changes
Aug 8, 2019
|
if/when this gets approved please dont insta merge it, going to do a full regression on storybook |
dr3
suggested changes
Aug 8, 2019
added 3 commits
August 8, 2019 14:04
dr3
approved these changes
Aug 8, 2019
sareh
reviewed
Aug 8, 2019
|
@dr3 One way to do that review is to go through each of the Chromatic QA snapshots and review the changes. Doing that now. |
|
@sareh true, dont entirely trust that yet :P But, ive reviewed them locally and no huge issues, any prop warnings etc can be fixed forward. LGTM, merge away |
This was referenced Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1665
Overall change: Move all of our dev dependencies into the top level psammead package.json
Testing: Storybook regression
Code changes: