Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Bump everything to psammead-styles 1.2.0 #1365

Merged
merged 6 commits into from
Jul 23, 2019
Merged

Bump everything to psammead-styles 1.2.0 #1365

merged 6 commits into from
Jul 23, 2019

Conversation

andrew-nowak
Copy link
Contributor

@andrew-nowak andrew-nowak commented Jul 18, 2019 •
edited by sareh
Loading

Resolves #NUMBER

Overall change: Brings in the sans-serif fixes and the new @supports ${grid} stuff

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@andrew-nowak andrew-nowak added ws-home Tasks for the WS Home Team simorgh-core-stream dependencies Pull requests that update a dependency file labels Jul 18, 2019
@andrew-nowak andrew-nowak self-assigned this Jul 18, 2019
@andrew-nowak andrew-nowak marked this pull request as ready for review July 18, 2019 14:57
ghost
ghost reviewed Jul 18, 2019
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. The rest looks fine.

@ghost
Copy link

ghost commented Jul 22, 2019

@aacn500 Resolve conflicts.

@andrew-nowak
Merge remote-tracking branch 'origin/latest' into psammead-styles-1-2-0
96610ae 
# Conflicts:
#	packages/components/psammead-inline-link/CHANGELOG.md
#	packages/components/psammead-inline-link/package-lock.json
#	packages/components/psammead-inline-link/package.json
@andrew-nowak
empty commit to trigger snyk
53fa7b7
sareh
sareh approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@sareh
Copy link
Contributor

sareh commented Jul 22, 2019

Note for testers: this update means that these changes will be included in the packages:

Version Description
1.2.0 PR#1234 Add custom CSS Grid feature detector
1.1.5 PR#1215 Fix sans serif typo in Persian Nassim font-family
1.1.4 PR#1066 Fix Serif Medium font to return Medium instead of Italic.

@andrew-nowak
Merge remote-tracking branch 'origin/latest' into psammead-styles-1-2-0
7068754 
# Conflicts:
#	packages/components/psammead-media-indicator/CHANGELOG.md
#	packages/components/psammead-media-indicator/package-lock.json
#	packages/components/psammead-media-indicator/package.json
#	packages/components/psammead-sitewide-links/CHANGELOG.md
@david-boydell david-boydell self-assigned this Jul 23, 2019
@david-boydell
Copy link

Hiya, this looks good and is ready for merge.

@andrew-nowak andrew-nowak merged commit b40b5cd into latest Jul 23, 2019
@andrew-nowak andrew-nowak deleted the psammead-styles-1-2-0 branch July 23, 2019 08:26
This was referenced Oct 3, 2019
Closed
Closed
This was referenced Oct 15, 2019
Closed
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dr3 dr3 dr3 left review comments

@j-pendlebury j-pendlebury j-pendlebury approved these changes

@sareh sareh sareh approved these changes

@pjlee11 pjlee11 Awaiting requested review from pjlee11

Assignees

@andrew-nowak andrew-nowak

@david-boydell david-boydell

Labels
dependencies Pull requests that update a dependency file high priority simorgh-core-stream ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andrew-nowak @sareh @david-boydell @dr3 @j-pendlebury @amywalkerdev