Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Apply font based on service: Headings #1241

Merged
6 commits merged into from
Jul 17, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 16, 2019

Contributes to #543

Overall change: Apply font style based on service prop

Code changes:

  • Add service prop on Headline and SubHeading
  • Update snapshots and tests

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@ghost ghost added the ws-home Tasks for the WS Home Team label Jul 16, 2019
@ghost ghost self-assigned this Jul 16, 2019
@ghost ghost marked this pull request as ready for review July 16, 2019 13:15
@ghost ghost requested review from dr3, j-pendlebury, pjlee11 and sareh as code owners July 16, 2019 13:15
@ghost ghost changed the title Apply font based on service Apply font based on service: Headings Jul 16, 2019
@david-boydell
Copy link

Looks good as always! Ready to merge :)

@andrew-nowak
Copy link
Contributor

@sadickisaac this PR has merge conflicts now

@ghost ghost merged commit 7ea3d01 into latest Jul 17, 2019
@ghost ghost deleted the use-font-functions-headlines branch July 17, 2019 15:45
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants