Allow faster file access over HTTP #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First test looks promising, I wait for further feedback from my ARD/ZDF collegues |
donkon
approved these changes
Jun 16, 2023
donkon
approved these changes
Jun 16, 2023
Can be used to speed up access in some cases that don't require random access or access to footer for complete header metadata. Seeking is enabled by default.
E.g. if `--http-disable-seek` is used then still output the file info if not other action has been selected.
Using this option will stop the reader indexing the locations of essence. That is useful if there are many partitions for example and it's more efficient to not index and instead treat the file as incomplete. It may not be efficient if essence is read and the --start option is used with a position not near the start. The footer is still searched for and used to extract header metadata (if available). This ensures that the most up-to-date metadata is used. The footer is found either using the RIP or the footerPartition property in the header partition pack.
philipnbbc
force-pushed
the
philipn-faster-http-mxf2raw
branch
from
d3c7cc3 to
81eb62b
Compare
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
--http-disable-seekoption that disables seeking for an input file read over HTTP. The file is treated like a stream. In cases where the header partition contains complete metadata, or incomplete if acceptable, and no seeking is required, then using this option can be more efficient as it avoids indexing the partitions and essence positions.--disable-indexing-filesoption that is similar and has the same advantages as--http-disable-seekbut it is not specific to HTTP and does try read the header metadata from the last partition as it may be more complete. It doesn't prevent the reader from seeking.mxf2rawwill output file info (by default) to when there are no options that specifically require an action like reading essence or metadata.mxf2raw --disable-indexing-fileswill therefore now return the file info.Addresses #13 (comment)