Exclude .git/ by default
#5542
Merged
Exclude .git/ by default
#5542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem === When many non-Ruby files exist, RuboCop is slow. Because RuboCop checks that all files match glob or not. And `git subtree` makes too many files under `.git/subtree-cache` directory. So, if user uses it, RuboCop will be too slow unfortunately. Note: I knew the problem from this blog post. http://blog.yujigraffiti.com/2018/02/rubocop.html (written in Japanese) I have not confirmed the problem in my environment as I don't use `git subtree`, but I think this change is reasonable even without the performance issue. Solution === Exclude `.git/` directory by default.
|
Makes sense to me. Perhaps it'd be nice if we did for other VCSes, but these days it seems pretty much everyone's on git anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When many non-Ruby files exist, RuboCop is slow. Because RuboCop checks that all files match glob or not.
And
git subtreemakes too many files under.git/subtree-cachedirectory. So, if user uses it, RuboCop will be too slow unfortunately.Note: I knew the problem from this blog post.
http://blog.yujigraffiti.com/2018/02/rubocop.html (written in Japanese)
I have not confirmed the problem in my environment as I don't use
git subtree, but I think this change is reasonable even without the performance issue.Solution
Exclude
.git/directory by default.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.