Remove the undefined TimeZone#strftime from Rails/TimeZone
#5402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up of rubocop#5381 (comment). It seems that there is a mistake in solving the Issue below. rubocop#1773 From Rails 4.2 to Rails 5.2 (beta), The following code will result in an error. ```console > str = '2015-03-02 19:05:37' > Time.zone.strftime(str, "%Y-%m-%d %H:%M%Z") NoMethodError: undefined method `strftime' for #<ActiveSupport::TimeZone:0x00007fdaed438c88> ``` AFIAK, `ActiveSupport::TimeZone#strftime` does not exist in Rails 4.2 at least. Previously, rubocop#1773 was thought to mistype `Time.zone.strftime` to `Time.zone.strptime`. However, I think that it was false positives because `ActiveSupport::TimeZone#strptime` introduced in Rails 5.0 does not exist in Rails 4.2. rails/rails@a5e507f In this PR, `ActiveSupport::TimeZone#strftime` which does not exist is removed from detection targets. I'm judging that this change has no effect on codes that works as expected.
koic
force-pushed
the
remove_a_dangerous_method_from_rails_time_zone
branch
from
614a7ad to
860f226
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #5381 (comment).
It seems that there is a mistake in solving the Issue below.
#1773
From Rails 4.2 to Rails 5.2 (beta), The following code will result in an error.
AFAIK,
ActiveSupport::TimeZone#strftimedoes not exist in Rails 4.2 at least.Previously, #1773 was thought to mistype
Time.zone.strftimetoTime.zone.strptime. However, I think that it was false positives becauseActiveSupport::TimeZone#strptimeintroduced in Rails 5.0 does not exist in Rails 4.2.rails/rails@a5e507f
In this PR,
ActiveSupport::TimeZone#strftimewhich does not exist is removed from detection targets.I'm judging that this change has no effect on codes that works as expected.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.