-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails/CreateTableWithTimestamps false positive #5503
Labels
Comments
wata727
added a commit
to wata727/rubocop
that referenced
this issue
Jan 25, 2018
Fixes rubocop#5503 When using `to_proc` syntax, `Rails/CreateTableWithTimestamps` cop doesn't report offenses even if specifying timestamps.
8 tasks
bbatsov
pushed a commit
that referenced
this issue
Jan 27, 2018
Fixes #5503 When using `to_proc` syntax, `Rails/CreateTableWithTimestamps` cop doesn't report offenses even if specifying timestamps.
malikolivier
added a commit
to malikolivier/lmml-on-rails
that referenced
this issue
Feb 28, 2018
This is a false positive, a bug in rubocop. Will be fixed in the next release: rubocop/rubocop#5503
Hi, I have
My file: class CreateAttachments < ActiveRecord::Migration[5.1]
def change
create_table :attachments, id: :string, limit: 42, &:timestamps
end
end |
8 tasks
wata727
added a commit
to wata727/rubocop
that referenced
this issue
May 9, 2018
See also: rubocop#5503 (comment) When using `create_table` with hash options, this Cop reports false positives.
bbatsov
pushed a commit
that referenced
this issue
May 14, 2018
See also: #5503 (comment) When using `create_table` with hash options, this Cop reports false positives.
koic
pushed a commit
to rubocop/rubocop-rails
that referenced
this issue
Oct 26, 2018
See also: rubocop/rubocop#5503 (comment) When using `create_table` with hash options, this Cop reports false positives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using
to_proc
syntax, theRails/CreateTableWithTimestamps
rule gives a false positive:Expected behavior
There should be no violation reported
Actual behavior
There is a violation reported
Steps to reproduce the problem
Run against a migration that looks like:
RuboCop version
Include the output of
rubocop -V
. Here's an example:The text was updated successfully, but these errors were encountered: