Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use behavior of rgrep/ag default string for projectile-grep/ag #1078

Closed
laz2 opened this issue Oct 29, 2016 · 8 comments
Closed

Use behavior of rgrep/ag default string for projectile-grep/ag #1078

laz2 opened this issue Oct 29, 2016 · 8 comments

Comments

@laz2
Copy link
Contributor

laz2 commented Oct 29, 2016

Cursor or selection on string "hello".

rgrep/ag minibuffer
Search for (default hello): <-- Field is empty

projectile-grep/ag minibuffer
[project] Search for: hello <-- Field isn't empty

If i want search with another string i must delete old. I see only one problem with this. If i want edit default search string i can not make that action. Is this good behavior? May i provide pull request?

@laz2
Copy link
Contributor Author

laz2 commented Oct 30, 2016

Something like this:

  • Cursor on symbol "hello":
    Search for (default hello): <-- Cann't edit default
  • Selection on symbol "hello":
    Search for: hello <-- Can edit default

@laz2
Copy link
Contributor Author

laz2 commented Nov 26, 2016

Is this good improvement or not?

@yauhen-l
Copy link

Vote for this change

@auvn
Copy link

auvn commented Nov 28, 2016

+1

1 similar comment
@iced
Copy link

iced commented Nov 28, 2016

+1

@laz2
Copy link
Contributor Author

laz2 commented Dec 15, 2016

Any comments from maintainers? Is this good or not?

@bbatsov
Copy link
Owner

bbatsov commented Dec 15, 2016

I'm fine with changing this. PR welcome. :-)

@laz2
Copy link
Contributor Author

laz2 commented Dec 15, 2016

PR #1083. But in PR i always add symbol at cursor or selected region to default (input is always empty like in original behavior of rgrep/ag)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants