Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test are broken at head #896

Open
aiuto opened this issue Sep 28, 2024 · 0 comments
Open

Test are broken at head #896

aiuto opened this issue Sep 28, 2024 · 0 comments
Labels
bug P1 An issue that must be resolved. Must have an assignee

Comments

@aiuto
Copy link
Collaborator

aiuto commented Sep 28, 2024

A few tests are broken at head because of a rules_python fix vs. recent Bazel changes.

The root cause might be https://buildkite.com/bazel/rules-pkg/builds/3359

The error indicates this is somewhere within the external repo tests, which build a WORKSPACE dynamically and test that we work when uses as a repo, rather than just testing behavior standalone.

(21:33:14) ERROR: no such package '@@[unknown repo 'mappings_test_external_repo' requested from @@]//pkg': The repository '@@[unknown repo 'mappings_test_external_repo' requested from @@]' could not be resolved: No repository visible as '@mappings_test_external_repo' from main repository. Was the repository introduced in WORKSPACE? The WORKSPACE file is disabled by default in Bazel 8 (late 2024) and will be removed in Bazel 9 (late 2025), please migrate to Bzlmod. See https://bazel.build/external/migration.

Thanks to anyone who wants to jump on this and fix it. Making them pass is probalby easy. Deciding if we should test this or just assume we work as a repository is a harder decision.

@aiuto aiuto added bug P1 An issue that must be resolved. Must have an assignee labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P1 An issue that must be resolved. Must have an assignee
Projects
None yet
Development

No branches or pull requests

1 participant