-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(concatjs): update karma to 6.3.2 and fix #2093 #2603
Conversation
@@ -4,6 +4,7 @@ | |||
*/ | |||
import * as crypto from 'crypto'; | |||
import * as fs from 'fs'; | |||
import * as File from 'karma/lib/file'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is somewhat hacky. We're probably not supposed to import from lib
Should we be bumping the peer dep here: https://github.com/bazelbuild/rules_nodejs/blob/stable/packages/concatjs/package.json#L25 ? Or this this API available in 4.0.0 too |
Nice catch. I forgot that there are separate We might not actually have to bump the peer dependency. The only key missing in the new File object that is present in the current implementation's object is We could still bump it to 5.1.0 just in case. What do you think? |
As the tests pass I think this shows it's backwards compatible - we could bump the version as part of the upcoming 4.0.0 milestone release if we wanted, then it's a clear breaking point. |
Sounds good to me. Thanks! |
PR Checklist
Please check if your PR fulfills the following requirements:
No new tests added, but one was fixed to work with the change.
Docs shouldn't need to be updated for this change.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2093
What is the new behavior?
Fixes #2093. Updates karma packages to latest versions.
Does this PR introduce a breaking change?
The old version of karma seems to still work with these changes (n = 2 tests), but I haven't extensively tested it.
Other information