fix(esbuild): add link_workspace_root for workspace absolute imports #2476
Conversation
jbedard
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
packages/esbuild/esbuild.bzl
Outdated
| @@ -15,6 +15,9 @@ def _esbuild_impl(ctx): | |||
| # how to resolve custom package or module names | |||
| path_alias_mappings = dict() | |||
|
|
|||
| if (ctx.attr.link_workspace_root): | |||
| path_alias_mappings.update(generate_path_mapping(ctx.workspace_name, "/".join(ctx.build_file_path.split("/")[:-1]))) | |||
There was a problem hiding this comment.
This would add:
"build_bazel_rules_nodejs": [
"packages/esbuild/test/typescript/index.mjs",
"packages/esbuild/test/typescript"
],
"build_bazel_rules_nodejs/*": [
"packages/esbuild/test/typescript/*"
]
to the path mappings. Wouldn't these need to point to the root of the workspace, which would be './*' rather than the root of where the esbuild rule is?
There was a problem hiding this comment.
Yeah you're right... the import examples in the test should be build_bazel_rules_nodejs/packages/esbuild/test/typescript/...subfolder.... I think that's actually what I originally had but was getting errors and confused (all because of a silly typo), and this is what came out of the confusion in the end...
There was a problem hiding this comment.
Updated, I think that's right now?
There was a problem hiding this comment.
For the test this now creates:
"paths": {
"build_bazel_rules_nodejs": [
"./index.mjs",
"."
],
"build_bazel_rules_nodejs/*": [
"./*"
]
}
There was a problem hiding this comment.
Yeah that looks correct, nice one!
jbedard
force-pushed
the
esbuild-workspace
branch
from
72bcfde to
75e47b5
Compare
Fixes #2474