Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtin): don't pass kwargs to generated_file_test .update binary #2361

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

alexeagle
Copy link
Collaborator

The test itself just runs diff, so it's always fast. This prevents warnings under bazel test --test_verbose_timeout_warnings
Note that the **kwargs are passed to both the binary and test targets here, so users can't pass this attribute

Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could pass size to just the test target as well so it is user configurable?

This allows you to set things like size or timeout to prevent warnings under bazel test --test_verbose_timeout_warnings
@alexeagle alexeagle changed the title fix(builtin): declare size=small on generated_file_test fix(builtin): don't pass kwargs to generated_file_test .update binary Dec 22, 2020
@alexeagle alexeagle merged commit afa095b into bazel-contrib:3.x Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants