fix(typescript): add .proto files from npm deps to inputs of ts_library #1991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
@bazel/typescript
is a dep of ts_library such asas seen in
packages/bazel/src/api-extractor/BUILD.bazel
in angular/angular, then the linker needs to includethird_party/github.com/bazelbuild/bazel/src/main/protobuf/worker_protocol.proto
as an input as worker.js will run out of its linked location in node_modules & only files that are inputs to ts_library will be there.The failure was only observed on Angular repo RBE since running ts_library has workers on by default it is not sandboxed.
Failure mode is:
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information