Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json files are not declared as output in ts_project #1988

Closed
longlho opened this issue Jul 1, 2020 · 2 comments
Closed

json files are not declared as output in ts_project #1988

longlho opened this issue Jul 1, 2020 · 2 comments

Comments

@longlho
Copy link
Contributor

longlho commented Jul 1, 2020

🚀 feature request

Relevant Rules

ts_project

Description

A clear and concise description of the problem or missing capability...

Followup from #1981

If outdir is specified, the JSON files get copied to it so ideally it should be part of js_outs (or its own json_outs).

Describe the solution you'd like

If you have a solution in mind, please describe it.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@alexeagle
Copy link
Collaborator

I'm a little confused, in the title you say they are not copied, but in the description you say they are copied.

@longlho
Copy link
Contributor Author

longlho commented Jul 1, 2020 via email •
edited
Loading

longlho added a commit to longlho/rules_nodejs that referenced this issue Jul 2, 2020
@longlho
fix(typescript): add json to ts_project DefaultInfo, fix bazel-contri…
c402749 
…b#1988
longlho added a commit to longlho/rules_nodejs that referenced this issue Jul 2, 2020
@longlho
fix(typescript): add json to ts_project DefaultInfo, fix bazel-contri…
e7f0dba 
…b#1988
longlho added a commit to longlho/rules_nodejs that referenced this issue Jul 2, 2020
@longlho
fix(typescript): add json to ts_project DefaultInfo, fix bazel-contri…
3f9dd4b 
…b#1988
@longlho longlho mentioned this issue Jul 2, 2020
Merged
12 tasks
longlho added a commit to longlho/rules_nodejs that referenced this issue Jul 2, 2020
@longlho
fix(typescript): add json to ts_project DefaultInfo, fix bazel-contri…
63ba8d9 
…b#1988
@longlho longlho changed the title json files do not get copied to outdir in ts_project json files are not declared as output in ts_project Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeagle @longlho @evahowe