Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollup worker does not pickup changes to rollup.config.js #1790

Closed
jbedard opened this issue Apr 5, 2020 · 0 comments
Closed

rollup worker does not pickup changes to rollup.config.js #1790

jbedard opened this issue Apr 5, 2020 · 0 comments
Assignees

Comments

@jbedard
Copy link
Collaborator

jbedard commented Apr 5, 2020

🐞 bug report

Affected Rule

rollup_bundle

Description

Changes to the rollup config are not picked up by the worker

🔬 Minimal Reproduction

Run a build with workers enabled and a config such as:

module.exports = {
  output: {
    chunkFileNames: '[name].js',
  }
}

Modify the config, for example:

module.exports = {
  output: {
    chunkFileNames: '[name]-IM-A-CHUNK.js',
  }
}

The rolled-up config file doesn't change (https://github.com/bazelbuild/rules_nodejs/blob/1.5.0/packages/rollup/src/index.js#L106)

Rules_nodejs version:
1.5.0

jbedard added a commit to jbedard/rules_nodejs that referenced this issue Apr 6, 2020
@jbedard jbedard self-assigned this Apr 6, 2020
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Apr 6, 2020
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Apr 8, 2020
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Apr 9, 2020
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Apr 9, 2020
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Apr 9, 2020
@jbedard jbedard closed this as completed in a19eb2b Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant