Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn cache path should be a string #1679

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

siddharthab
Copy link
Contributor

@siddharthab siddharthab commented Mar 1, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • [] Tests for the changes have been added (for bug fixes / features)
  • [] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue: #1678

What is the new behavior?

Does this PR introduce a breaking change?

  • [] Yes
  • No

Other information

Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@gregmagolan
Copy link
Collaborator

Fixes #1678

@gregmagolan gregmagolan added the bug label Mar 1, 2020
@gregmagolan gregmagolan merged commit a43809b into bazel-contrib:master Mar 2, 2020
@siddharthab siddharthab deleted the 1.3.x branch March 2, 2020 02:56
@siddharthab
Copy link
Contributor Author

Thank you for the quick merge. Do you have guidance on when this change will be in a release? Or can I use the commit hash directly?

@alexeagle
Copy link
Collaborator

We don't publish release snapshots yet, and the layout of the source repo doesn't match what we publish (has a bunch of development dependencies for example) so the easy way to pull this into your project is to patch it, see https://github.com/bazelbuild/rules_nodejs/blob/master/docs/index.md#patching-the-built-in-release

@siddharthab
Copy link
Contributor Author

Thanks! A patch file should work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants