Generated npm_umd_bundle misses package scope in package_name

[ashi009]

🐞 bug report

Affected Rule

npm_umd_bundle

https://github.com/gregmagolan/rules_nodejs/blob/27e2b68da628f5dd1c9f109f2cf605a30f4b7baa/internal/npm_install/generate_build_file.js#L533

Is this a regression?

No

Description

For scoped packages, the ts_devserver will require() the package using it's scoped package name (say, @scope/pkg). However, the generated umd file only uses the last segment of the name (pkg), which doesn't match the required name.

🔬 Minimal Reproduction

git clone https://github.com/ashi009/rules_nodejs_npm_umd_bundle.git
cd rules_nodejs_npm_umd_bundle
bazel run :devserver

🔥 Exception or Error

ts_scripts.js:1962 GET http://localhost:5432/@blueprintjs/core.js net::ERR_ABORTED 404 (Not Found)
req.load @ ts_scripts.js:1962
load @ ts_scripts.js:1686
load @ ts_scripts.js:835
fetch @ ts_scripts.js:825
check @ ts_scripts.js:857
enable @ ts_scripts.js:1177
enable @ ts_scripts.js:1558
(anonymous) @ ts_scripts.js:1162
(anonymous) @ ts_scripts.js:135
each @ ts_scripts.js:60
enable @ ts_scripts.js:1114
enable @ ts_scripts.js:1558
(anonymous) @ ts_scripts.js:1162
(anonymous) @ ts_scripts.js:135
each @ ts_scripts.js:60
enable @ ts_scripts.js:1114
init @ ts_scripts.js:789
(anonymous) @ ts_scripts.js:1461
setTimeout (async)
req.nextTick @ ts_scripts.js:1816
localRequire @ ts_scripts.js:1450
requirejs @ ts_scripts.js:1798
(anonymous) @ ts_scripts.js:43529
12:12:24.940 ts_scripts.js:169 Uncaught Error: Script error for "@blueprintjs/core", needed by: umd/index
http://requirejs.org/docs/errors.html#scripterror
    at makeError (ts_scripts.js:169)
    at HTMLScriptElement.onScriptError (ts_scripts.js:1739)
makeError @ ts_scripts.js:169
onScriptError @ ts_scripts.js:1739
error (async)
req.load @ ts_scripts.js:1944
load @ ts_scripts.js:1686
load @ ts_scripts.js:835
fetch @ ts_scripts.js:825
check @ ts_scripts.js:857
enable @ ts_scripts.js:1177
enable @ ts_scripts.js:1558
(anonymous) @ ts_scripts.js:1162
(anonymous) @ ts_scripts.js:135
each @ ts_scripts.js:60
enable @ ts_scripts.js:1114
enable @ ts_scripts.js:1558
(anonymous) @ ts_scripts.js:1162
(anonymous) @ ts_scripts.js:135
each @ ts_scripts.js:60
enable @ ts_scripts.js:1114
init @ ts_scripts.js:789
(anonymous) @ ts_scripts.js:1461
setTimeout (async)
req.nextTick @ ts_scripts.js:1816
localRequire @ ts_scripts.js:1450
requirejs @ ts_scripts.js:1798
(anonymous) @ ts_scripts.js:43529

🌍 Your Environment

Operating System:

  
macOS 10.14.6
  

Output of bazel version:

  
$ bazel version
Build label: 0.29.0
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Wed Aug 28 14:37:40 2019 (1567003060)
Build timestamp: 1567003060
Build timestamp as int: 1567003060
  

Rules version (SHA):

  
0.36.2
  

Anything else relevant?

[ghost]

I am also having this issue with @material-ui/core. Did you find a workaround?

[ashi009]

We didn't want to dig too deep into this as we only use it in devserver. So for now, we patched the [build file generator][1] to generate the rule with the proper package name. You can create a patch in your workspace and use the patch attribute on the rules_nodejs repository rule to apply it without forking. [1]: https://github.com/bazelbuild/rules_nodejs/blob/162e4369dfed0dc7eaf7d9b7463305d7da4d2416/internal/npm_install/generate_build_file.js#L943 Arthur <[email protected]>于2019年9月11日 周三上午1:57写道：

I am also having this issue. Did you find a workaround? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1095>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFH2B2VUQZMYYVB6EPX5B3QI7NZVANCNFSM4ITZEM3A> .

-- Sent from Gmail Mobile

[ghost]

Thank you! I’ll give this a shot.

…

Sent from my iPhone

On Sep 11, 2019, at 07:46, Xiaoyi ***@***.***> wrote: We didn't want to dig too deep into this as we only use it in devserver. So for now, we patched the [build file generator][1] to generate the rule with the proper package name. You can create a patch in your workspace and use the patch attribute on the rules_nodejs repository rule to apply it without forking. [1]: https://github.com/bazelbuild/rules_nodejs/blob/162e4369dfed0dc7eaf7d9b7463305d7da4d2416/internal/npm_install/generate_build_file.js#L943 Arthur ***@***.***>于2019年9月11日 周三上午1:57写道： > I am also having this issue. Did you find a workaround? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#1095>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAFH2B2VUQZMYYVB6EPX5B3QI7NZVANCNFSM4ITZEM3A> > . > -- Sent from Gmail Mobile — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[pyle]

Also came across where import '@polymer/paper-progress'; would fail with the same error above.
Changing to import 'paper-progress' removes this error and the component/devserver loads the page.
Only problem is when changing to import 'paper-progress'; this then fails in module resolution for a rollup_bundle()

I've not found problems with packages that aren't namespaces like import {} 'lit-element';
Also not isolated to just @polymer/* packages, other webcomponents throw the same import error but load in rollup_bundle/web_package

afaik 0.38.3 should have the patch above unless im missing something.

Example build rule:

ts_library(
    name = "main",
    srcs = ["main.ts"],
    tsconfig = ":tsconfig.json",
    deps = [
        "//shared_app",
        "@npm//@webcomponents/webcomponentsjs",
        "@npm//lit-html",
    ],
)

ts_devserver(
    name = "devserver",
    additional_root_paths = [
        "npm/node_modules/core-js/client",
        "npm/node_modules/systemjs/dist",
    ],
    data = [
        "//assets",
        "@npm//:node_modules/core-js/client/core.min.js",
        "@npm//:node_modules/systemjs/dist/system.js",
    ],
    entry_module = "ui/main",
    index_html = "index.html",
    static_files = _ASSETS,
    deps = [
        ":main",
        "@npm//@polymer/paper-progress:paper-progress__umd",
        "@npm//lit-element:lit-element__umd",
    ],
)

http_archive(
    name = "build_bazel_rules_nodejs",
    sha256 = "ad4be2c6f40f5af70c7edf294955f9d9a0222c8e2756109731b25f79ea2ccea0",
    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.38.3/rules_nodejs-0.38.3.tar.gz"],
)