Skip to content

Commit

Permalink
fix(builtin): provide proper error if npm_package_bin has no outs (#2557
Browse files Browse the repository at this point in the history
)
  • Loading branch information
alexeagle authored Mar 26, 2021
1 parent e92bc7a commit c47b770
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/node/npm_package_bin.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def _inputs(ctx):
def _impl(ctx):
if ctx.attr.output_dir and ctx.outputs.outs:
fail("Only one of output_dir and outs may be specified")
if not ctx.attr.output_dir and not ctx.outputs.outs and not ctx.attr.stdout:
if not ctx.attr.output_dir and not len(ctx.outputs.outs) and not ctx.attr.stdout:
fail("One of output_dir, outs or stdout must be specified")

args = ctx.actions.args()
Expand Down

0 comments on commit c47b770

Please sign in to comment.