feat(builtin): turn off a strict requirement for peer dependencies (#…

…1163)
bazel-contrib · Oct 16, 2019 · bd2f108 · bd2f108
1 parent f915703
commit bd2f108
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/npm_install/generate_build_file.js b/internal/npm_install/generate_build_file.js
@@ -696,7 +696,7 @@ def _maybe(repo_rule, name, **kwargs):
             });
         }
         findDeps(dep.dependencies, true, 'dependency');
-        findDeps(dep.peerDependencies, true, 'peer dependency');
+        findDeps(dep.peerDependencies, false, 'peer dependency');
         // `optionalDependencies` that are missing should be silently
         // ignored since the npm/yarn will not fail if these dependencies
         // fail to install. Packages should handle the cases where these

diff --git a/internal/npm_install/generate_build_file.ts b/internal/npm_install/generate_build_file.ts
@@ -779,7 +779,7 @@ function flattenPkgDependencies(pkg: Dep, dep: Dep, pkgsMap: Map<string, Dep>) {
   }
 
   findDeps(dep.dependencies, true, 'dependency');
-  findDeps(dep.peerDependencies, true, 'peer dependency');
+  findDeps(dep.peerDependencies, false, 'peer dependency');
   // `optionalDependencies` that are missing should be silently
   // ignored since the npm/yarn will not fail if these dependencies
   // fail to install. Packages should handle the cases where these